Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cached_property dependency. #1980

Merged
merged 6 commits into from
May 2, 2023
Merged

Remove cached_property dependency. #1980

merged 6 commits into from
May 2, 2023

Conversation

Gamenot
Copy link
Collaborator

@Gamenot Gamenot commented Apr 24, 2023

This dependency is no longer needed with python3.8.

@Gamenot
Copy link
Collaborator Author

Gamenot commented Apr 27, 2023

Annoyingly it looks like pytype cannot figure out that functools.cached_property is returning an integer.

@Gamenot Gamenot mentioned this pull request Apr 28, 2023
Open
17 tasks
@Gamenot Gamenot merged commit 76c2e9c into master May 2, 2023
@Gamenot Gamenot deleted the tucker/remove-cached_property branch May 2, 2023 15:36
@Gamenot
Copy link
Collaborator Author

Gamenot commented May 2, 2023

Updating pytype fixed the issues with functools.cached_property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adaickalavan Adaickalavan Adaickalavan approved these changes

@saulfield saulfield saulfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gamenot @saulfield @Adaickalavan