Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix traffic_histories_to_observations script #1987

Merged
merged 5 commits into from
Apr 27, 2023
Merged

Conversation

saulfield
Copy link
Contributor

Fixes #1976.

@@ -122,7 +123,7 @@ def observe_batch(
self,
sim_frame: SimulationFrame,
sim_local_constants: SimulationLocalConstants,
agent_id,
interface: AgentInterface,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@Gamenot Gamenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to see that we can at least partially extract the agent ids from observe.

Copy link
Contributor

@qianyi-sun qianyi-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much Saul!

@saulfield saulfield merged commit 09f90ee into master Apr 27, 2023
@saulfield saulfield deleted the saul/obs-script-fix branch April 27, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] traffic_histories_to_observations.py script is broken on master branch
4 participants