Make sumo dependencies optional #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Gamenot
requested changes
Jun 9, 2023
Comment on lines
+50
to
+56
| try: | ||
| import sumo.tools.sumolib as sumolib | ||
| import sumo.tools.traci as traci | ||
| except ModuleNotFoundError as e: | ||
| raise ImportError( | ||
| "Missing dependencies for SUMO. Install them using the command `pip install -e .[sumo]` at the source directory." | ||
| ) from e |
There was a problem hiding this comment.
I can note that all versions of the "hiway" environment import SumoTrafficSimulation as well as traffic_histories_to_observations.py.
Please update those appropriately.
There was a problem hiding this comment.
SUMO is now optional for these environments, though they still have optional params that are SUMO-specific that I did not touch.
Adaickalavan
approved these changes
Jun 12, 2023
Gamenot
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #1981.