Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heterogenous Agent Computing #236

Merged
merged 26 commits into from
Dec 1, 2020
Merged

Heterogenous Agent Computing #236

merged 26 commits into from
Dec 1, 2020

Conversation

davidrusu
Copy link
Contributor

@davidrusu davidrusu commented Nov 30, 2020 •
edited
Loading

This PR contains a first pass at Heterogeneous Agent Computing.

The main idea is that we have the Zoo Worker installed on a server and listens for SMARTS sessions requesting remote social agents.

# on a server
scl zoo worker

# locally

gym.make(..., zoo_workers=[("143.125.34.1", 1200)])

Sequence diagram for SMARTS allocating a remote social agent
zoo-compute-sequence-diagram

@davidrusu davidrusu marked this pull request as draft November 30, 2020 21:31
@davidrusu davidrusu marked this pull request as ready for review November 30, 2020 23:23
@liamchzh liamchzh mentioned this pull request Nov 30, 2020
Merged
@davidrusu davidrusu requested a review from a team December 1, 2020 03:38
JVillella
JVillella reviewed Dec 1, 2020
View reviewed changes
envision/web/src/index.js
@@ -26,7 +26,7 @@ import App from "./components/app.js";
import "antd/dist/antd.dark.css";

let client = new Client({
endpoint: "http://localhost:8081",
endpoint: window.location.origin,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This includes the port I take it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, sure does

JVillella
JVillella approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@JVillella JVillella left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, thanks for the review last night on the design. Perhaps attach the diagram to this PR for record keeping (could also put it in the wiki)?

@liamchzh
Copy link
Contributor

liamchzh commented Dec 1, 2020

A giant step on HAC!

Gamenot
Gamenot approved these changes Dec 1, 2020
View reviewed changes
examples/single_agent.py Outdated Show resolved Hide resolved
smarts/zoo/worker.py Outdated Show resolved Hide resolved
@Gamenot
Copy link
Collaborator

Gamenot commented Dec 1, 2020

🚢

@davidrusu davidrusu merged commit 245ce6c into master Dec 1, 2020
@davidrusu davidrusu deleted the smarts-on-server branch December 1, 2020 16:37
@davidrusu davidrusu mentioned this pull request Dec 1, 2020
Closed
6 tasks
@Adaickalavan Adaickalavan mentioned this pull request Jun 21, 2022
Merged
@Adaickalavan Adaickalavan mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adaickalavan Adaickalavan Adaickalavan approved these changes

@Gamenot Gamenot Gamenot approved these changes

@JVillella JVillella JVillella approved these changes

@liamchzh liamchzh liamchzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidrusu @liamchzh @Gamenot @JVillella @Adaickalavan