Convention is to call these methods setXyz. Plus doc

hub4j · Oct 28, 2017 · e94ba74 · e94ba74
1 parent 569fa06
commit e94ba74
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/main/java/org/kohsuke/github/GHLabel.java b/src/main/java/org/kohsuke/github/GHLabel.java
@@ -35,7 +35,11 @@ public void delete() throws IOException {
         repo.root.retrieve().method("DELETE").to(url);
     }
 
-    public void updateColor(String newColor) throws IOException {
+    /**
+     * @param newColor
+     *      6-letter hex color code, like "f29513"
+     */
+    public void setColor(String newColor) throws IOException {
         repo.root.retrieve().method("PATCH").with("name", name).with("color", newColor).to(url);
     }
 }
diff --git a/src/test/java/org/kohsuke/github/AppTest.java b/src/test/java/org/kohsuke/github/AppTest.java
@@ -754,7 +754,7 @@ public void testRepoLabel() throws IOException {
             assertEquals(t.getColor(), t2.getColor());
             assertEquals(t.getUrl(), t2.getUrl());
 
-            t.updateColor("000000");
+            t.setColor("000000");
             GHLabel t3 = r.getLabel("test");
             assertEquals(t3.getColor(), "000000");
             t.delete();