Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHRepository assumes public github.com, won't work with github enterprise #64

Closed
ryankennedy opened this issue Jan 16, 2014 · 2 comments

Comments

@ryankennedy
Copy link
Contributor

https://github.com/kohsuke/github-api/blob/master/src/main/java/org/kohsuke/github/GHRepository.java#L96

GHRepository doesn't take into account whether or not the client is speaking with the public github.com or if it's talking to a github enterprise instance. Consequently, when you call getGitTransportUrl() or gitHttpTransportUrl() it only ever returns a github.com URL, which won't work for github enterprise hosted repositories.

@kohsuke
Copy link
Collaborator

kohsuke commented Apr 13, 2014

As I do not have access to GitHub Enterprise, a pull request would be greatly appreciated.

kohsuke added a commit that referenced this issue May 10, 2014
This fixes issue #64.
@kohsuke
Copy link
Collaborator

kohsuke commented May 10, 2014

Fixed toward 1.53.

@kohsuke kohsuke closed this as completed May 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants