Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use issues endpoints for pull requests #123

Merged
merged 2 commits into from
Sep 4, 2014
Merged

Use issues endpoints for pull requests #123

merged 2 commits into from
Sep 4, 2014

Commits on Sep 3, 2014

  1. Separate out clean-up of Pull requests created during test 

    If the test assertion fails, we want the pull-request to be closed anyway.
You can't have more than one pull-request merging a given branch into
another, so leaving the PR hanging will cause subsequent test runs to fail
in setup.
    @rtyley
    rtyley committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    1a9b8bd View commit details
    Browse the repository at this point in the history

  2. Fix setting labels and assignee on PullRequests 

    Setting labels and assignee on Pull requests failed silently, because
the API endpoint being hit contained '/pulls/' rather than '/issues/'.

"Every pull request is an issue, but not every issue is a pull request.
For this reason, “shared” actions for both features, like manipulating
assignees, labels and milestones, are provided within the Issues API."

https://developer.github.com/v3/pulls/#labels-assignees-and-milestones
    @rtyley
    rtyley committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    e2220bb View commit details
    Browse the repository at this point in the history