Allow pullRequest.getHead().getRepository().getCommit(headSha1) to work #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong .wrap method was used for pull requests initialized by state (GHRepository.getPullReqests). The wrong wrap call was introduced in 9fd34ae This commit sets it back to the .wrapUp method which makes sure the pull request substructure has the repo object set properly. Without this change a NullPointerException is thrown on the last line of this code because the repo object inside of the remoteRepository object is null: GHRepository repo = github.getRepository(targetRepository); List<GHPullRequest> openPullRequests = repo.getPullRequests(GHIssueState.OPEN); for (GHPullRequest pullRequest : openPullRequests) { GHCommitPointer head = pullRequest.getHead(); GHRepository remoteRepository = head.getRepository(); String commitId = head.getSha(); GHCommit headCommit = remoteRepository.getCommit(commitId);
|
Kohsuke Kawaguchi » github-api #234 SUCCESS |
mocleiri
added a commit
that referenced
this pull request
Sep 26, 2014
…t-commit Allow pullRequest.getHead().getRepository().getCommit(headSha1) to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong .wrap method was used for pull requests initialized by state
(GHRepository.getPullReqests).
The wrong wrap call was introduced in 9fd34ae
This commit sets it back to the .wrapUp method which makes sure the pull request
substructure has the repo object set properly.
Without this change a NullPointerException is thrown on the last line of this
code because the repo object inside of the remoteRepository object is null:
GHRepository repo = github.getRepository(targetRepository);
List openPullRequests = repo.getPullRequests(GHIssueState.OPEN);
for (GHPullRequest pullRequest : openPullRequests) {