Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to get the list of languages using in repository #161

Merged
merged 2 commits into from
Mar 13, 2015

Conversation

khoa-nd
Copy link
Contributor

@khoa-nd khoa-nd commented Mar 5, 2015

Hi kohsuke
I used your API to call Github API but I found that there isn't any method lists all languages using in repository. Therefore, I ask you to add it into your master code.
Thanks

@buildhive
Copy link

Kohsuke Kawaguchi » github-api #285 SUCCESS
This pull request looks good
(what's this?)

"Python": 7769
}
*/
public Map<String,Integer> listLanguages() throws IOException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Size in bytes, max Integer will be 2Gb, i think some crazy repo may have such number. Long looks better.

@buildhive
Copy link

Kohsuke Kawaguchi » github-api #286 SUCCESS
This pull request looks good
(what's this?)

@khoa-nd
Copy link
Contributor Author

khoa-nd commented Mar 6, 2015

Hi KostyaSha ,
Thanks for your feedback. I already changed the code as you mentioned

@KostyaSha
Copy link
Contributor

Thanks, looks good for me, let's wait @kohsuke

oleg-nenashev added a commit that referenced this pull request Mar 13, 2015
Add method to get the list of languages using in repository
@oleg-nenashev oleg-nenashev merged commit d95c8a4 into hub4j:master Mar 13, 2015
@oleg-nenashev
Copy link
Collaborator

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants