Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub API have changed the semantics of /user/repos API #203

Merged

Conversation

lucamilanesio
Copy link
Contributor

It seems that since a couple of days (or weeks?) the /user/repos is returning
ALL the repositories that the user has access or collaborates to whilst previously
were only the ones that belong to him.

JavaDoc updated in order to avoid getting unwanted results and introduced as well
the possibility to filter a specific type of repository to be returned:
- All (the GitHub's default)
- Owner (the user's repos)
- Public / Private (public or private repos)
- Member (the user collaborates to)

@buildhive
Copy link

Kohsuke Kawaguchi » github-api #358 SUCCESS
This pull request looks good
(what's this?)

@lucamilanesio lucamilanesio force-pushed the ghmyself-getrepositories-semantic-change branch from 641e601 to e30962f Compare June 26, 2015 09:05
@lucamilanesio lucamilanesio changed the title GitHub API have changed the semantics of /user/repos API: docs updated. GitHub API have changed the semantics of /user/repos API Jun 26, 2015
@buildhive
Copy link

Kohsuke Kawaguchi » github-api #359 SUCCESS
This pull request looks good
(what's this?)

@lucamilanesio
Copy link
Contributor Author

@kohsuke this patch is very urgent since GitHub API have been rolled out two days ago with the new semantics :-( Can you have a look today if makes sense?

* Type of repositories returned during listing.
*/
public enum RepositoryType {
All, // All public and private repositories that current user has access or collaborates to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enum should be CAPITAL_CASED

you can rewrite toString() method if want to change string representation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I've decided to use name().toLowerCase() instead of relying on the toString() override.

It seems that since a couple of days (or weeks?) the /user/repos is returning
ALL the repositories that the user has access or collaborates to whilst previously
were only the ones that belong to him.

JavaDoc updated in order to avoid getting unwanted results and introduced as well
the possibility to filter a specific type of repository to be returned:
- All (the GitHub's default)
- Owner (the user's repos)
- Public / Private (public or private repos)
- Member (the user collaborates to)
@lucamilanesio lucamilanesio force-pushed the ghmyself-getrepositories-semantic-change branch from e30962f to b0d1eac Compare June 26, 2015 12:42
@buildhive
Copy link

Kohsuke Kawaguchi » github-api #360 SUCCESS
This pull request looks good
(what's this?)

@lucamilanesio
Copy link
Contributor Author

@lanwen all changes done, thanks for your feedback.

@kohsuke kohsuke merged commit b0d1eac into hub4j:master Jul 17, 2015
kohsuke added a commit that referenced this pull request Jul 17, 2015
@lucamilanesio lucamilanesio deleted the ghmyself-getrepositories-semantic-change branch March 2, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants