-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub API have changed the semantics of /user/repos API #203
GitHub API have changed the semantics of /user/repos API #203
Conversation
Kohsuke Kawaguchi » github-api #358 SUCCESS |
641e601
to
e30962f
Compare
Kohsuke Kawaguchi » github-api #359 SUCCESS |
@kohsuke this patch is very urgent since GitHub API have been rolled out two days ago with the new semantics :-( Can you have a look today if makes sense? |
* Type of repositories returned during listing. | ||
*/ | ||
public enum RepositoryType { | ||
All, // All public and private repositories that current user has access or collaborates to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enum should be CAPITAL_CASED
you can rewrite toString() method if want to change string representation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I've decided to use name().toLowerCase() instead of relying on the toString() override.
It seems that since a couple of days (or weeks?) the /user/repos is returning ALL the repositories that the user has access or collaborates to whilst previously were only the ones that belong to him. JavaDoc updated in order to avoid getting unwanted results and introduced as well the possibility to filter a specific type of repository to be returned: - All (the GitHub's default) - Owner (the user's repos) - Public / Private (public or private repos) - Member (the user collaborates to)
e30962f
to
b0d1eac
Compare
Kohsuke Kawaguchi » github-api #360 SUCCESS |
@lanwen all changes done, thanks for your feedback. |
It seems that since a couple of days (or weeks?) the /user/repos is returning
ALL the repositories that the user has access or collaborates to whilst previously
were only the ones that belong to him.