Skip to content

Conversation

@if6was9
Copy link

@if6was9 if6was9 commented Sep 21, 2015

this addresses #218

@buildhive
Copy link

Kohsuke Kawaguchi » github-api #394 SUCCESS
This pull request looks good
(what's this?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catch should be after } -> } catch {

@lanwen
Copy link
Contributor

lanwen commented Sep 21, 2015

👎 For now.

I think it should be:

  1. Get the owners. (Can it be exception here? If not, skip 2 step)
  2. Use default owner names if exc.
  3. If owners equals, use getCompare(id1.getName(), id2.getName());
  4. Else format owner:branch and use getCompare with that

@buildhive
Copy link

Kohsuke Kawaguchi » github-api #395 SUCCESS
This pull request looks good
(what's this?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid empty lines in count more than one

@buildhive
Copy link

Kohsuke Kawaguchi » github-api #396 SUCCESS
This pull request looks good
(what's this?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add space after ,

@lanwen
Copy link
Contributor

lanwen commented Sep 27, 2015

👍 after some code style fixes

@buildhive
Copy link

Kohsuke Kawaguchi » github-api #397 SUCCESS
This pull request looks good
(what's this?)

@oleg-nenashev
Copy link
Collaborator

As I see from the code, null owners are not supposed to happen. BTW I'm not sure I've investigated all potential cases.

👍 in any case, because the original behavior smells like a bug

kohsuke added a commit that referenced this pull request Dec 1, 2015
@kohsuke kohsuke merged commit 723bb89 into hub4j:master Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants