Remove trailing slash when requesting directory content #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shredder121
force-pushed
the
directory-content-trailing-slash
branch
from
0522742
to
7dc571e
Compare
|
Kohsuke Kawaguchi » github-api #398 FAILURE |
|
Could someone restart the build 😄 |
|
Kohsuke Kawaguchi » github-api #399 SUCCESS |
|
Only merge if it's an issue that we should fix. |
Shredder121
force-pushed
the
directory-content-trailing-slash
branch
from
7dc571e
to
092e906
Compare
|
Kohsuke Kawaguchi » github-api #400 SUCCESS |
|
I have no strong opinion about the fix, but it looks reasonable to me. |
|
Sorry, have no opinion. Will it be possible to make some test case? |
|
I did so just now. |
kohsuke
added a commit
that referenced
this pull request
Dec 1, 2015
…lash Remove trailing slash when requesting directory content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed something strange on GitHub's end.
When requesting content from a directory (with a specific ref), you get ref-specific content.
Now look closely what happens when you add a trailing slash.
What is your view on this?