Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animal sniffer #259

Merged
merged 5 commits into from
Mar 19, 2016
Merged

Animal sniffer #259

merged 5 commits into from
Mar 19, 2016

Conversation

Shredder121
Copy link
Contributor

Hello @kohsuke.

Seeing as you recently set the compiler target back to 5, I wanted to help you maintain this compatibility.
There is still one unresolved issue:

--- animal-sniffer-maven-plugin:1.15:check (ensure-java-1.5-class-library) @ github-api ---
Checking unresolved references to org.codehaus.mojo.signature:java15:1.0
X:\Git\github\github-api\src\main\java\org\kohsuke\github\GHContent.java:81: Undefined reference: byte[] javax.xml.bind.DatatypeConverter.parseBase64Binary(String)
X:\Git\github\github-api\src\main\java\org\kohsuke\github\GHContent.java:182: Undefined reference: String javax.xml.bind.DatatypeConverter.printBase64Binary(byte[])
X:\Git\github\github-api\src\main\java\org\kohsuke\github\GHRepository.java:1165: Undefined reference: String javax.xml.bind.DatatypeConverter.printBase64Binary(byte[])

Hope that you can integrate this.

@Shredder121
Copy link
Contributor Author

@KostyaSha Could you please voice your concern via comments?
The new reactions don't trigger notifications.
I am very interested in the obstacles.

kohsuke added a commit that referenced this pull request Mar 19, 2016
@kohsuke kohsuke merged commit 7307bec into hub4j:master Mar 19, 2016
@Shredder121 Shredder121 deleted the animal-sniffer branch March 19, 2016 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants