Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fields of GHRepository #304

Merged
merged 1 commit into from
Nov 17, 2016
Merged

Fix fields of GHRepository #304

merged 1 commit into from
Nov 17, 2016

Conversation

wolfogre
Copy link
Contributor

@wolfogre wolfogre commented Nov 3, 2016

According to the lasted version of https://developer.github.com/v3/repos/#get , the fields of GHRepository need be fixed:

  • Add new field has_pages ;
  • Add new field stargazers_count, Be careful, Pull request Add stargarzer field to GHRepository #301 did the same thing
  • Rename forks to forks_count, forks still works, but you can't see it in the newest docs;
  • Rename watchers to watchers_count, watchers still works, but you can't see it in the newest docs;
  • Rename open_issues to open_issues_count, open_issues still works, but you can't see it in the newest docs;
  • Delete network_count, I am not sure what it means, but it is always same as forks_count, and of coursed you can't see it in the newest docs;

I did some basic tests, this is the result:

kohsuke/github-api:
hasPages:true
getForksCount:241
getStargazersCount:307
getWatchersCount:307
getOpenIssueCount:17

You may notice that the watchers_count is same as stargazers_count, it is not a bug in my code, you can see the same situation in the docs, and the subscribers_count is the real watcher count.

@kohsuke kohsuke merged commit 955e989 into hub4j:master Nov 17, 2016
kohsuke added a commit that referenced this pull request Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants