Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add offline support to the API to make parsing events easier #306

Merged
merged 10 commits into from
Nov 17, 2016
Merged

Add offline support to the API to make parsing events easier #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4daf6ba
Add offline support to the API to make parsing events easier
stephenc Nov 8, 2016
5b92d4b
Fix findbugs false alarms
stephenc Nov 8, 2016
ce3f742
Ensure a use case required by github-plugin is valid
stephenc Nov 8, 2016
7bf8621
Need the pusher details for github-plugin
stephenc Nov 8, 2016
66145e1
Seems there is an undocumented but important PING event used by githu…
stephenc Nov 8, 2016
7dc620a
More details emerge on the PingEvent payload
stephenc Nov 8, 2016
498d63e
Typos spotted by Jesse
stephenc Nov 8, 2016
d36e145
Need to be able to tell if this is a creation / deletion of a ref for…
stephenc Nov 11, 2016
9988a09
Add some more tests
stephenc Nov 11, 2016
e544c7a
Fix the push event payload
stephenc Nov 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions src/main/java/org/kohsuke/github/GHCommitComment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,7 @@ public class GHCommitComment extends GHObject {
String body, html_url, commit_id;
Integer line;
String path;
User user;

static class User {
// TODO: what if someone who doesn't have an account on GitHub makes a commit?
@SuppressFBWarnings(value = "UUF_UNUSED_FIELD", justification = "We don't provide it in API now")
String url,avatar_url,gravatar_id;
@SuppressFBWarnings(value = "UUF_UNUSED_FIELD", justification = "We don't provide it in API now")
int id;

String login;
}
GHUser user; // not fully populated. beware.

public GHRepository getOwner() {
return owner;
Expand Down Expand Up @@ -76,7 +66,7 @@ public int getLine() {
* Gets the user who put this comment.
*/
public GHUser getUser() throws IOException {
return owner.root.getUser(user.login);
return owner == null || owner.root.isOffline() ? user : owner.root.getUser(user.login);
}

/**
Expand Down Expand Up @@ -110,6 +100,9 @@ private String getApiTail() {

GHCommitComment wrap(GHRepository owner) {
this.owner = owner;
if (owner.root.isOffline()) {
user.wrapUp(owner.root);
}
return this;
}
}
Loading