Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-36240] /repos/:owner/:repo/collaborators/:username/permission no longer requires korra preview #358

Merged
merged 1 commit into from
Sep 8, 2017

Conversation

jglick
Copy link
Contributor

@jglick jglick commented Jun 12, 2017

JENKINS-36240

Amends #324 (and its unfiled follow-ups). This API seems to now be official.

@reviewbybees esp. @stephenc & @kohsuke

@ghost
Copy link

ghost commented Jun 12, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick
Copy link
Contributor Author

jglick commented Jun 12, 2017

@reviewbybees done

Copy link
Collaborator

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 and @reviewbybees done
I can merge this PR, but KK is required to release it

@jglick
Copy link
Contributor Author

jglick commented Sep 8, 2017

@kohsuke ping

@kohsuke kohsuke merged commit 29b5357 into hub4j:master Sep 8, 2017
@jglick jglick deleted the no-preview-JENKINS-36240 branch October 4, 2017 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants