Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added archived attribute in GHRepository #470

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Conversation

recena
Copy link
Contributor

@recena recena commented Oct 25, 2018

  • archived attribute was missed and can be interesting in many cases
  • Updated parent POM from 17 to 20
  • Addressed a Apache Maven warning
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.kohsuke:github-api:jar:1.95-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-surefire-plugin is missing. @ line 37, column 15
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING] 

@kohsuke, could you take a look? Thanks.

@recena recena changed the title Added archived attribute in GHRepository. Updated the parent POM Added archived attribute in GHRepository Oct 25, 2018
@kohsuke kohsuke merged commit 8e85bf8 into hub4j:master Oct 29, 2018
@brian-mcnamara
Copy link

@recena Thanks for this, I was actually just about to implement this as I need it too! Thank you!

@kohsuke I would love to use this for our project. Can we create a release?

@nielsutrecht
Copy link

@kohsuke +1 from me, I'm running into an issue where I'm mass creating pull requests that are failing on archived repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants