Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub API requests logging #530

Merged
merged 4 commits into from
Oct 4, 2019
Merged

Conversation

bozaro
Copy link
Contributor

@bozaro bozaro commented Jul 19, 2019

This information is very useful on GitHub API rate limit exhaustion investigation.

@bitwiseman bitwiseman closed this Aug 24, 2019
@bitwiseman bitwiseman reopened this Aug 24, 2019
@bitwiseman
Copy link
Member

@bozaro
This is looks reasonable. Need some tests for it. Maybe you can try out the mocking framework, I've added and create some tests the verify the logging output?

@bitwiseman bitwiseman merged commit 78abb2e into hub4j:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants