Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to update and delete milestones. #579

Merged

Conversation

martinvanzijl
Copy link
Contributor

Fixes #512.

Adds the following methods to GHMilestone:

  • setTitle
  • setDescription
  • setDueOn
  • delete

NOTE: For the unit test, the returned due date doesn't quite match the one passed to setDueOn. I guess this is due to timezone difference.

@bitwiseman bitwiseman merged commit 6956922 into hub4j:master Oct 30, 2019
@martinvanzijl martinvanzijl deleted the issue_512_methods_to_update_milestones branch November 1, 2019 00:56
Copy link
Contributor Author

@martinvanzijl martinvanzijl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, thanks for the updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Methods to update milestones
2 participants