Add method to list repository topics #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For hub4j#546. The method to update repository topics does not work yet. It may not have been implemented in the underlying API.
bitwiseman
reviewed
Oct 30, 2019
| @@ -1744,4 +1744,29 @@ String getApiTailUrl(String tail) { | |||
| public GHIssueEvent getIssueEvent(long id) throws IOException { | |||
| return root.retrieve().to(getApiTailUrl("issues/events/" + id), GHIssueEvent.class).wrapUp(root); | |||
| } | |||
|
|
|||
| // Only used within getTopics(). | |||
There was a problem hiding this comment.
Sorry, I mean "listTopics()". I've updated the comment now.
| * Set the topics for this repository. | ||
| * See https://developer.github.com/v3/repos/#replace-all-topics-for-a-repository | ||
| */ | ||
| // This currently returns a "404" error (as of 30 Oct 2019). |
There was a problem hiding this comment.
Hm, interesting problem. Do you want to try to figure it out before merging or do you believe it is a bug on their side?
There was a problem hiding this comment.
I guess it is a bug on their side. I also tried using curl which gave a "404" response, too. Shall I raise a query with GitHub support?
I suggest merging the getter method but keeping the issue open, so we know to re-visit later and add the setter method.
There was a problem hiding this comment.
Sure merging this makes sense.
|
Thanks! I also raised a query to GitHub support to ask whether the setter feature is enabled yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #546.
Adds method
GHRepository.listTopics.NOTE: The method to update repository topics does not work yet, so I have commented it out. It may not have been implemented in the underlying API. I recommend keeping the issue open until this is working.