Enable org member filtering #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Organization members are a paged list in the V3 GitHub API. Previously the code would fetch only the first page of ~30 members and return that. This change switches the return to a PagedIterable<GHUser> so clients can fetch the entire organization's member list.
|
Kohsuke Kawaguchi » github-api #127 SUCCESS |
|
The new API functionality was announced here... http://developer.github.com/changes/2014-01-29-audit-org-members-for-2fa/ ...it's the only way the API exposes the information about who has 2FA and who doesn't. |
rtyley
added a commit
to guardian/gu-who
that referenced
this pull request
Feb 24, 2014
I've published a small fork of the github-api, which includes these pull-requests we need: hub4j/github-api#66 - org member paging hub4j/github-api#68 - org-member filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option of supplying a parameter to the get members method so that we can call the filter by two factor authentication method