Addressed issue #133 #207
Merged
Addressed issue #133 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dealing with mismatching socket/core topolgoies in VM settings
|
Thanks a lot for this PR, I think the code to be changed is more in the qemu exporter itself : https://github.com/hubblo-org/scaphandre/blob/main/src/exporters/qemu.rs#L75 This code is too simple to handle multiple vcpu in the VM. It has to be changed. I'll try to make something up for the release 0.6. In the mean time if you want to give it a try do not hesitate ! |
|
got it working on a 2 cores vm, I'll merge your work in this PR : #291 thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, while trying to use scaphandre with the qemu I encountered the issue #133. Looking into it a bit more, the reason behind this stems from the way qemu (at least for my setup) handles multi-core/multi-thread CPUs. In essence, instead of allowing you to set core or thread count for the virtual CPU, you add sockets to the VM; see this stack overflow discussion.
So to fix this I just fall back to the first socket found by the sensor and add all encountered cores to it. Sorry if the code is ugly, I'm new to rust. Anyway, with this fix, u can use the VM mode even for VM's with more vCores.