Config update + extras #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved configuration on to SeoObjectExtension to be more in line with other modules, and made SEO tab show for all page types by default
The google search result preview would not always load the first time, requiring the meta description field to be edited to trigger population.
This can mean a big performance improvement for websites hosted on slower servers
|
Hi Jonom, Thanks a lot! Inversing the usage of the SEO module is a very good idea indeed. I saw a topic on the SS forum from someone who had questions about this as well because the configuration was not clear. I will merge your pull request next week. And will create a new release for it (2.0) Feel free to edit the readme and be sure to mention your name with these fixes ? Cheers, Bart |
|
Thanks for the merge and shout out ;) |
helpfulrobot
pushed a commit
to helpfulrobot/micschk-silverstripe-liveseo
that referenced
this pull request
Dec 16, 2015
FIX: Ensure the entire URL is used when check for page subject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Bart,
I noticed that by default this module only applies to pages using the generic 'Page' class. I think that most of the time you will want the SEO tab to be available on custom page types, and it will be a rare few pages where you will want to hide it. With this PR I've changed the configuration so that you only have to specify which pages will not include the SEO tab, otherwise it will be included by default. Makes it quicker to get up and running out of the box and means you don't have to add an entry to the SEO config each time you add a new page type to a project.
I also reinstated the google suggest filed in this PR and fixed a little issue where the preview wouldn't always load. (Resolves #9)
The config updates aren't backwards compatible so I guess if you accept this PR it would justify a major release number if you're following semver. I didn't update the ReadMe.md to go with the changes as I wasn't sure you'd approve of them - but let me know if you want me to do that.