Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address npm ci slowdown #2753

Merged
merged 14 commits into from
Jul 18, 2022
Merged

Address npm ci slowdown #2753

merged 14 commits into from
Jul 18, 2022

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Jul 13, 2022

Cypress runs in just over 10 minutes... typical of duration before regression.
We'll need to make sure that our dev environments are up to date and in sync with these changes.

Disabled a portion of one test. If you think you understand the problem, great... otherwise I'd vote for filing an issue to sort it out later, and merge the rest of this now.

@mccalluc
Copy link
Contributor Author

Hitting node-sass / gyp problem now.

@mccalluc
Copy link
Contributor Author

mccalluc commented Jul 13, 2022

dev-start working locally now. With any luck tests will pass, and complete in less time: The last couple commits have been more copy-and-paste from SO than I'd like.

@mccalluc
Copy link
Contributor Author

RUN npm ci fails with peer dependency conflicts... because we don't COPY the conf file...

@mccalluc
Copy link
Contributor Author

mccalluc commented Jul 13, 2022

Cypress passes! Installs seem to work, but Node tests fail early. There's a lot of upgrading here, and maybe the behavior of something we rely on has changed?

  /home/runner/work/portal-ui/portal-ui/context/node_modules/jsdom/lib/jsdom/living/xhr/XMLHttpRequest-impl.js:111
        referrer: _ownerDocument.URL,
                                 ^
...
      at /home/runner/work/portal-ui/portal-ui/context/app/static/js/hooks/useImmediateDescendantProv.js:131:32
      at Array.map (<anonymous>)
      at _callee$ (/home/runner/work/portal-ui/portal-ui/context/app/static/js/hooks/useImmediateDescendantProv.js:126:57)
      at tryCatch (/home/runner/work/portal-ui/portal-ui/context/node_modules/regenerator-runtime/runtime.js:45:40)

potentially relevant post: https://dev.to/vnglst/did-you-forget-to-wait-something-async-in-your-test-59j7 ... Problem might be with test cleanup?

Maybe there's a way to change jest logging to see what test it had started before the error? Or assume it's the other test in that directory: context/app/static/js/components/entity-search/SearchWrapper/utils.spec.js

end-to-end/.npmrc Outdated Show resolved Hide resolved
@mccalluc mccalluc marked this pull request as ready for review July 14, 2022 02:50
@mccalluc mccalluc requested a review from john-conroy July 14, 2022 02:55
@@ -1 +1 @@
v14.19.3
v16.16.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember; were the issues you described here the only issues blocking us from using node 16 when we pinned to 14?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My memory is that we just didn't want to take too big of a jump all at once, and the format change in package-lock.json was a little scary.

@mccalluc mccalluc merged commit ceb158b into main Jul 18, 2022
@mccalluc mccalluc deleted the mccalluc/npm-upgrade branch July 18, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress has gotten much slower
2 participants