-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address npm ci
slowdown
#2753
Address npm ci
slowdown
#2753
Conversation
Hitting node-sass / gyp problem now. |
dev-start working locally now. With any luck tests will pass, and complete in less time: The last couple commits have been more copy-and-paste from SO than I'd like. |
|
Cypress passes! Installs seem to work, but Node tests fail early. There's a lot of upgrading here, and maybe the behavior of something we rely on has changed?
potentially relevant post: https://dev.to/vnglst/did-you-forget-to-wait-something-async-in-your-test-59j7 ... Problem might be with test cleanup? Maybe there's a way to change jest logging to see what test it had started before the error? Or assume it's the other test in that directory: |
@@ -1 +1 @@ | |||
v14.19.3 | |||
v16.16.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remember; were the issues you described here the only issues blocking us from using node 16 when we pinned to 14?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My memory is that we just didn't want to take too big of a jump all at once, and the format change in package-lock.json was a little scary.
Cypress runs in just over 10 minutes... typical of duration before regression.
We'll need to make sure that our dev environments are up to date and in sync with these changes.
Disabled a portion of one test. If you think you understand the problem, great... otherwise I'd vote for filing an issue to sort it out later, and merge the rest of this now.