-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NickAkhmetov/HMP-159 Upgrade vitessce-python dependency #81
NickAkhmetov/HMP-159 Upgrade vitessce-python dependency #81
Conversation
use schema version 1.0.15 use vitessce version 3.0.6
…old SPRM datasets, troubleshoot tooltip contents
added vs code ruler to make it easier to spot when lines are too long
…update RNASeqAnnDataZarrViewConfBuilder tests
Current state:
Sample vitessce config with the marker genes issue
|
I put together a local draft release of
I verified these changes work as expected locally; CI fails for this branch because 3.0.7 is not yet a released Vitessce version. Once those three PR's are merged and a new release is made, I will update the test fixtures again and open this PR for review. I've also preemptively pushed a |
Ergo, I'm opening this for review. |
@@ -0,0 +1,3 @@ | |||
{ | |||
"editor.rulers": [100] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this .vscode config as a guide to avoid long comment lines that broke lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if my review is valuable here, but looks good to me!
@@ -50,7 +62,7 @@ def get_conf_cells(self, marker=None): | |||
if f'{zarr_path}/.zgroup' not in file_paths_found: | |||
message = f'RNA-seq assay with uuid {self._uuid} has no .zarr store at {zarr_path}' | |||
raise FileNotFoundError(message) | |||
vc = VitessceConfig(name=self._uuid) | |||
vc = VitessceConfig(name=self._uuid, schema_version='1.0.15') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we define schema_version
somewhere for reuse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great call! I've added this as a private field in the BaseBuilder
which allows for overrides to be done (if ever needed) by passing schema_version
to the args of any builder.
"coordination_values": { | ||
"obsType": "cell", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be worth introducing a util or similar for coordination_values
? There is a bit of repetition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a create_coordination_values
util which:
- Returns `{ "obsType": "cell" } by default (most common case)
- Can have a different
obs_type
specified by passing an arg (first positional arg or namedobs_type
) - Can have other keys specified as named args, e.g.
embeddingType="UMAP"
After resolving John's comments above and getting verbal approval from Mark via slack, I'm merging these changes in 🙌 |
This PR updates the
vitessce-python
dependency from 1.0.9 to 3.0.5; this was done as part of troubleshooting HMP-296. There are still failing tests etc, which will be updated accordingly once the core issue in 296 is resolved.