Fixes client-side closed issue events causing exceptions after rails upgrade #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -99,7 +99,7 @@ def drag_card | |||
| message = { | |||
| :issue => @issue, | |||
There was a problem hiding this comment.
So why does this work if :current_user doesn't?
|
Is there any reasonable way to write a test for this? Should we also guard client-side against a missing |
|
huboard-web/app/jobs/issue_event_job.rb Line 56 in f371abb |
|
It's really a one off, pretty much any event missing an actor would cause an exception - we could probably write some testing around the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous rails upgrade (#237) changed the way ActiveJob serializes hashes, this cause an unexpected breakage in this job causing the actor to be null.
Closes huboard/huboard#647