Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to sendPrivate #4

Closed
wants to merge 1 commit into from

Conversation

selenamarie
Copy link

The IRC adapter added sendPrivate for redirecting long output to privmsg. Making this the default on IRC would be amazing.

IDK if people want to add something to configure it to send to channel, but in most cases, I don't think people want all the output going to the whole IRC channel by default.

The IRC adapter added `sendPrivate` for redirecting long output to privmsg. Making this the default on IRC would be amazing. 

IDK if people want to add something to configure it to send to channel, but in most cases, I don't think people want all the output going to the whole IRC channel by default.
@therealklanni
Copy link
Contributor

Can you add tests to cover this?

@therealklanni
Copy link
Contributor

Please also take a look at #1 (comment) to see if you want to take a crack at the suggestion given there.

Namely something along the lines of

      switch robot.adapterName
        when 'slack'
          if robot.messageRoom
            robot.messageRoom msg.envelope.user.id, emit
        when 'irc'
          if msg.sendPrivate
            msg.sendPrivate emit
        when 'hipchat'
          robot.send msg.user, emit

If you have time to implement it, the help would be greatly appreciated. I know a lot of Hubot users would love to have better help responses. If not, no worries, your contributions are definitely appreciated either way. 👍

@technicalpickles
Copy link
Member

We could merge this, but I think it'll only really help IRC users currently, as I don't know of any other adapters using msg.sendPrivate. It seems like we might need something upstream in hubot core to allow sending privately so things like hipchat, irc, slackchat could use it.

@TobiTenno
Copy link

I think this could be valuable if any movement has been made on it.

@stale stale bot added the stale label Jun 1, 2017
@stale
Copy link

stale bot commented Jun 1, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mose
Copy link
Member

mose commented Jun 2, 2017

I'm closing that PR because in the while, HUBOT_HELP_REPLY_IN_PRIVATE was implemented, which addresses this issue.

@mose mose closed this Jun 2, 2017
joeyguerra added a commit that referenced this pull request Jun 9, 2023
…t pollution

BREAKING CHANGE: Depends on a new version of Hubot, 4.x
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants