-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to sendPrivate #4
Conversation
The IRC adapter added `sendPrivate` for redirecting long output to privmsg. Making this the default on IRC would be amazing. IDK if people want to add something to configure it to send to channel, but in most cases, I don't think people want all the output going to the whole IRC channel by default.
Can you add tests to cover this? |
Please also take a look at #1 (comment) to see if you want to take a crack at the suggestion given there. Namely something along the lines of switch robot.adapterName
when 'slack'
if robot.messageRoom
robot.messageRoom msg.envelope.user.id, emit
when 'irc'
if msg.sendPrivate
msg.sendPrivate emit
when 'hipchat'
robot.send msg.user, emit If you have time to implement it, the help would be greatly appreciated. I know a lot of Hubot users would love to have better help responses. If not, no worries, your contributions are definitely appreciated either way. 👍 |
We could merge this, but I think it'll only really help IRC users currently, as I don't know of any other adapters using |
I think this could be valuable if any movement has been made on it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'm closing that PR because in the while, |
…t pollution BREAKING CHANGE: Depends on a new version of Hubot, 4.x
🎉 This issue has been resolved in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The IRC adapter added
sendPrivate
for redirecting long output to privmsg. Making this the default on IRC would be amazing.IDK if people want to add something to configure it to send to channel, but in most cases, I don't think people want all the output going to the whole IRC channel by default.