Fix typo-s in robot class #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdimkov
force-pushed
the
fix-typos-in-robot-class
branch
from
b0d6154 to
a42e903
Compare
| @@ -392,7 +392,6 @@ class Robot | |||
| # Returns nothing. | |||
| parseHelp: (path) -> | |||
| @logger.debug "Parsing help for #{path}" | |||
| scriptName = Path.basename(path).replace /\.(coffee|js)$/, '' | |||
There was a problem hiding this comment.
#917 actually depends on this being present. In addition, I'd much prefer to have test cases in place before modifying this code.
|
Please remove the code change per my comments and I'll merge |
sdimkov
force-pushed
the
fix-typos-in-robot-class
branch
from
a42e903 to
e721aa2
Compare
|
I've removed the commit. Are you sure #917 will get merged in the near future? It's open for the last 3 months I agree with you in general about the importance of tests and coverage.Yet in this particular case that argument makes very little sense. |
technicalpickles
added a commit
that referenced
this pull request
Jul 17, 2015
Fix typo-s in robot class
I'm not really sure of it. I left my feedback down in #917 (comment) there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.