Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to set up authentication with hubot #655

Closed
wants to merge 4 commits into from
Closed

How to set up authentication with hubot #655

wants to merge 4 commits into from

Conversation

jjasghar
Copy link
Contributor

I made a post on my blog, it seems like something that should be in the
docs.

@kewubenduben
Copy link

+1

I see that you're good at using hubot and helped providing documentation. Can you also add a documentation on how to use something like oauth from oauth.coffee?

@jjasghar
Copy link
Contributor Author

I haven't played with oauth.coffee yet, so i'll take a look :)

@jjasghar
Copy link
Contributor Author

@kewubenduben
Copy link

@jjasghar, correct. Lots of scripts that uses oauth but never have been a proper documentation on how to make use of it.

@jjasghar
Copy link
Contributor Author

I'll give it a shot, thanks for the heads up! 👍

@technicalpickles
Copy link
Member

Thanks for putting this together! The main entry point to docs is https://github.com/github/hubot/blob/master/docs/README.md, so you'd want to make sure it gets linked somewhere.

This sounds like a pattern though, so maybe move it to docs/patterns/authentication.coffee, and link to it from docs/patterns.md?

I think that would make sense for docs/patterns/oauth.coffee as well.

@technicalpickles
Copy link
Member

I also think this needs some editing. You mention it came from a blog post, and definitely reads like one.

In particular, it starts out assume you know you want authentication, when it should probably explain what it is. I think this is actually about authorization, not authentication, ie that someone has a particular role, not that they are a specific person.

You'd want the flow to be like... explaining what this authorization is, and why you want it, then go into configuration, and lastly using it from scripts.

Make sense?

@jjasghar
Copy link
Contributor Author

@technicalpickles Perfect sense. I'll attempt a re-write, but it's good to know that ya'll are interested. I'll attempt to get it written over the weekend. Updates when i got em.

@jjasghar
Copy link
Contributor Author

@technicalpickles any comments?

@technicalpickles
Copy link
Member

@jjasghar looks good, thanks for applying those changes! Looks good to merge.

cc @patcon in case this changes anything for hubot-auth

@patcon
Copy link

patcon commented Mar 13, 2014

Thanks! I'm not sure what to do with this until #656 is merged or tweaked or decided upon, so I guess I'd say that's a block :)

@michaelansel
Copy link
Collaborator

Linking for posterity to #768 - I'm working on providing a more generalized method of authorization policy. Hoping to have it done in a couple months.

# Authorization for Hubot

Authorization is the ability to scope certain commands for certain people. This is accomplished by two scripts and redis that come with
the basic install of hubot: [auth.coffee](https://github.com/github/hubot/blob/master/src/scripts/auth.coffee) and [roles.coffee](https://github.com/github/hubot/blob/master/src/scripts/roles.coffee). This tutorial is designed to get a basic understanding of setting it up, so you concentrate on figuring out where to use it as quickly as possible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These scripts aren't included by default any more, so probably should point to the extracted scripts.

@michaelansel
Copy link
Collaborator

Closing now that #803 has merged (including guidance for setting up custom authorization policies)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants