Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples with node v20 #19

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Examples with node v20 #19

wants to merge 25 commits into from

Conversation

Iru89
Copy link
Contributor

@Iru89 Iru89 commented Feb 20, 2024

Description

Removes nlp dependencies (package.json folder and scripts)
Upgrade versions of the dependencies
Update the package.json scripts: use webpack-dev-server in start script and add the deploy script.
Add jest.config.js

Context

Blank examples must not have any nlp dependencies.
Remove @babel/plugin-proposal-object-rest-spread, @babel/plugin-proposal-class-properties because both are in ECMAScript standard

Approach taken / Explain the design

To document / Usage example

Testing

The pull request...

  • has unit tests
  • has integration tests
  • doesn't need tests because... [provide a description]

@Iru89
Copy link
Contributor Author

Iru89 commented Feb 20, 2024

Would it be interesting to use @botonic/dx to encapsulate all devDependecies and tsconfig, babel, eslint, jest configurations?

@Iru89 Iru89 requested a review from AinaVendrell February 20, 2024 17:15
@Iru89 Iru89 force-pushed the examples-node-v20 branch from 68aef6b to 74c6811 Compare February 21, 2024 08:27
@Iru89 Iru89 force-pushed the examples-node-v20 branch from 02e6987 to 4140677 Compare February 21, 2024 16:10
@Iru89 Iru89 force-pushed the examples-node-v20 branch from 129c216 to 0b27a9e Compare February 22, 2024 12:10
@Iru89 Iru89 changed the title Examples blank and blank-typescript with node v20 Examples with node v20 Feb 22, 2024
Copy link

@alexgimenez02 alexgimenez02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

.github/workflows/templates-tests.yml Outdated Show resolved Hide resolved
blank-typescript/babel.config.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants