Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade examples to webpack 5 #5

Merged
merged 9 commits into from
Dec 16, 2020
Merged

chore: upgrade examples to webpack 5 #5

merged 9 commits into from
Dec 16, 2020

Conversation

vanbasten17
Copy link
Contributor

Description

  • Migration to webpack 5

@vanbasten17 vanbasten17 force-pushed the chore/upgrade-to-webpack-5 branch 3 times, most recently from b8f3953 to 37747dc Compare December 3, 2020 19:26
dpinol
dpinol suggested changes Dec 10, 2020
View reviewed changes
blank/webpack.config.js Outdated Show resolved Hide resolved
@vanbasten17 vanbasten17 force-pushed the chore/upgrade-to-webpack-5 branch from 2caa744 to c242e68 Compare December 14, 2020 08:47
@vanbasten17 vanbasten17 force-pushed the chore/upgrade-to-webpack-5 branch 2 times, most recently from aa0da50 to ba03c48 Compare December 14, 2020 12:13
@vanbasten17 vanbasten17 force-pushed the chore/upgrade-to-webpack-5 branch from ba03c48 to 897203e Compare December 14, 2020 15:02
@vanbasten17 vanbasten17 force-pushed the chore/upgrade-to-webpack-5 branch from 94bf987 to 62174da Compare December 14, 2020 17:04
asastre
asastre reviewed Dec 15, 2020
View reviewed changes
Copy link

@asastre asastre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice upgrade and refactor!!! 💯 I've put some comments/suggestions/questions about the changes made 😉
I've just reviewed the blank example, I guess the other ones will be the same, right?
By the way, is webpack.config.js from the blank-typescript missing?

blank/webpack.config.js Outdated Show resolved Hide resolved
blank/webpack.config.js Show resolved Hide resolved
blank/webpack.config.js Outdated Show resolved Hide resolved
blank/webpack.config.js Outdated Show resolved Hide resolved
blank/webpack.config.js Outdated Show resolved Hide resolved
blank/webpack.config.js Outdated Show resolved Hide resolved
blank/webpack.config.js Show resolved Hide resolved
blank/webpack.config.js Show resolved Hide resolved
asastre
asastre approved these changes Dec 16, 2020
View reviewed changes
Copy link

@asastre asastre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the moon 🌔 🚀!!

dpinol
dpinol approved these changes Dec 16, 2020
View reviewed changes
Copy link

@dpinol dpinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the PR title since not only "blank example" is affected

@vanbasten17 vanbasten17 changed the title chore: upgrade blank to webpack 5 chore: upgrade examples to webpack 5 Dec 16, 2020
@vanbasten17 vanbasten17 merged commit b9c7d4f into master Dec 16, 2020
@vanbasten17 vanbasten17 deleted the chore/upgrade-to-webpack-5 branch December 16, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosCA MarcosCA MarcosCA approved these changes

@dpinol dpinol dpinol approved these changes

@asastre asastre asastre approved these changes

@ericmarcos ericmarcos Awaiting requested review from ericmarcos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vanbasten17 @asastre @dpinol @MarcosCA