Contentful/lazy language engines #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpinol
force-pushed
the
contentful/lazy-language-engines
branch
from
8a98d6c to
46fa59b
Compare
asastre
approved these changes
Dec 5, 2020
Comment on lines
151
to
152
| [locales.CROATIAN]: () => new TokenizerHr(), | ||
| [locales.SLOVAK]: () => new TokenizerSk(), |
There was a problem hiding this comment.
Why TokenizerHr and TokenizerSk are always imported? Shouldn't they be lazy loaded too?
There was a problem hiding this comment.
I didn't do it because require() failed initially, but I found out that it works it you specify the extension
Comment on lines
84
to
85
| hr: () => new StemmerHr(), | ||
| sk: () => new StemmerSk(), |
There was a problem hiding this comment.
Why StemmerHr and StemmerSk are always imported? Shouldn't they be lazy loaded too?
| sk: new StemmerSk(), | ||
| } | ||
| const stemmers = new SingletonMap<Stemmer>({ | ||
| ca: () => { |
There was a problem hiding this comment.
Would be better to use the constants for the keys (locales.CATALAN instead of ca)?
vanbasten17
approved these changes
Dec 9, 2020
dpinol
force-pushed
the
contentful/lazy-language-engines
branch
from
46fa59b to
977f052
Compare
for performance reasons, and also to avoid failures in case an unused language tokenizer/stemmer cannot be loaded (eg. due to bug in browser)
languageFromLocale does the same
for performance reasons, and also to avoid failures in case an unused language tokenizer/stemmer cannot be loaded (eg. due to bug in browser)
dpinol
force-pushed
the
contentful/lazy-language-engines
branch
from
977f052 to
71951aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1118
Description
Only import nlp-js stemmers and tokenizers when using them.
removed rootLocale, as it did the same as languageFromLocale
Context
Approach taken / Explain the design
Testing
The pull request has unit tests