Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nlp): Hungarian added to contenful #1248

Merged
merged 2 commits into from
Jan 18, 2021
Merged

chore(nlp): Hungarian added to contenful #1248

merged 2 commits into from
Jan 18, 2021

Conversation

elozano98
Copy link
Contributor

@elozano98 elozano98 commented Jan 14, 2021

Depends on #1247. Please, review it first. ⚠️

Description

Hungarian tokenizer, stemmer, and stopwords have been added to contentful nlp.

Context

Adding them will make it possible to process Hungarian text.

Approach taken / Explain the design

The tokenizer and the stemmer used are from the nlpjs library while the stopwords have been collected from here.

Testing

The pull request...

  • has unit tests

@elozano98 elozano98 changed the title wip(nlp): Slovenian added to contenful wip(nlp): Hungarian added to contenful Jan 14, 2021
@elozano98 elozano98 changed the base branch from master to contentful/sl January 14, 2021 11:21
@elozano98 elozano98 marked this pull request as draft January 15, 2021 07:59
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #1248 (faa1fb3) into contentful/sl (c839d58) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           contentful/sl    #1248      +/-   ##
=================================================
+ Coverage          64.55%   64.58%   +0.03%     
=================================================
  Files                230      231       +1     
  Lines               6429     6436       +7     
  Branches            1115     1115              
=================================================
+ Hits                4150     4157       +7     
+ Misses              1967     1966       -1     
- Partials             312      313       +1     
Flag Coverage Δ
botonic-plugin-contentful 71.12% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/botonic-plugin-contentful/src/nlp/locales.ts 100.00% <100.00%> (ø)
...kages/botonic-plugin-contentful/src/nlp/stemmer.ts 95.55% <100.00%> (+0.20%) ⬆️
...lugin-contentful/src/nlp/stopwords/stopwords-hu.ts 100.00% <100.00%> (ø)
...ckages/botonic-plugin-contentful/src/nlp/tokens.ts 95.83% <100.00%> (+0.13%) ⬆️
...lugin-contentful/src/contentful/contents/button.ts 76.92% <0.00%> (-1.93%) ⬇️
...plugin-contentful/src/contentful/cms-contentful.ts 88.65% <0.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c839d58...faa1fb3. Read the comment docs.

@elozano98 elozano98 marked this pull request as ready for review January 15, 2021 11:36
@elozano98 elozano98 requested review from dpinol, vanbasten17, asastre and ericmarcos and removed request for dpinol January 15, 2021 11:36
@elozano98 elozano98 changed the title wip(nlp): Hungarian added to contenful chore(nlp): Hungarian added to contenful Jan 15, 2021
Base automatically changed from contentful/sl to master January 18, 2021 08:41
@elozano98 elozano98 merged commit 0d2cd6d into master Jan 18, 2021
@elozano98 elozano98 deleted the contentful/hu branch January 18, 2021 08:41
@elozano98 elozano98 added the documentation Documentation changes label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants