fix(contentful): Reimplementation of the stemmer-uk without lookbehind regex.

[elozano98]

Description

The stemmer used for Ukrainian had lookbehind regex that was not supported by Safari, so it has been implemented without including that type of unsupported regex.

Context

Is trying to fix this bug reported by @vanbasten17 in this issue.

Approach taken / Explain the design

The stemmer has been reimplemented in Botonic contentful but replacing the lookbehind regex.

Testing

The pull request...

• has unit tests
• has integration tests

[codecov]

Codecov Report

Merging #1289 (de12a05) into master (00ae962) will increase coverage by 0.15%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
+ Coverage   64.71%   64.87%   +0.15%     
==========================================
  Files         236      237       +1     
  Lines        6471     6514      +43     
  Branches     1118     1126       +8     
==========================================
+ Hits         4188     4226      +38     
- Misses       1968     1970       +2     
- Partials      315      318       +3     

Flag	Coverage Δ
botonic-plugin-contentful	71.47% <88.88%> (+0.19%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...c-plugin-contentful/src/nlp/stemmers/stemmer-uk.ts	88.37% <88.37%> (ø)
...kages/botonic-plugin-contentful/src/nlp/stemmer.ts	95.91% <100.00%> (ø)
...c-plugin-contentful/src/nlp/stemmers/stemmer-hr.ts	74.07% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ae962...de12a05. Read the comment docs.

[dpinol]

amazing!
can you create a PR for node-nlp, also? or a ticket for it if you have something urgent

[vanbasten17]

we already have warned there @dpinol : axa-group/nlp.js#741 👍