Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): integrations removed #1292

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Conversation

elozano98
Copy link
Contributor

@elozano98 elozano98 commented Feb 3, 2021

Description

Integrations have been removed from botonic core.

Documentation

Integrations with js are not supported anymore.

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #1292 (7c79871) into master (49ca577) will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1292      +/-   ##
==========================================
+ Coverage   60.78%   61.02%   +0.24%     
==========================================
  Files         248      247       -1     
  Lines        7097     7069      -28     
  Branches     1193     1193              
==========================================
  Hits         4314     4314              
+ Misses       2456     2428      -28     
  Partials      327      327              
Flag Coverage Δ
botonic-core 44.96% <ø> (+3.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/botonic-core/src/core-bot.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49ca577...7c79871. Read the comment docs.

@dpinol dpinol added the documentation Documentation changes label Feb 5, 2021
@dpinol
Copy link
Contributor

dpinol commented Feb 5, 2021

@elozano98 I added the documentation label to the PR. Please add the "to document" section to the PR description and specify it's a breaking change

@elozano98 elozano98 merged commit caabd50 into master Feb 5, 2021
@elozano98 elozano98 deleted the chore/deprecate-integration branch February 5, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants