-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): update lastMessageUpdate consistently with Webchat Settings #1355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since WebchatSettings
is not a message by itself I don't know if it make sense to update the last message date. What do you think?
@asastre it's true that is not a message itself, but when resending unread messages from backend, the last message update date should be taken into account in order to not send additional WebchatSettings messages. |
ce0c0ff
to
5fdab44
Compare
Codecov Report
@@ Coverage Diff @@
## master #1355 +/- ##
==========================================
- Coverage 63.20% 63.19% -0.01%
==========================================
Files 252 252
Lines 7075 7076 +1
Branches 1182 1182
==========================================
Hits 4472 4472
- Misses 2261 2262 +1
Partials 342 342
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5fdab44
to
183405a
Compare
183405a
to
c88fbe1
Compare
@asastre , you were right, there is no need to update the lastMessageDate. When doing the auth call, last message id will be the previous one just before the WebchatSettings in DB. So I'm closing this PR atm. It's a backend issue. |
Description
Linked PR: https://github.com/metis-ai/hubtype-backend/pull/552