fix(cli): pass -c flag to build command #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten17
force-pushed
the
fix/cli-c-flag
branch
from
6c310eb to
3096e01
Compare
asastre
reviewed
May 25, 2021
packages/botonic-cli/README.md
Outdated
| @@ -21,7 +21,7 @@ $ npm install -g @botonic/cli | |||
| $ botonic COMMAND | |||
| running command... | |||
| $ botonic (-v|--version|version) | |||
| @botonic/cli/0.18.5 darwin-x64 node-v12.21.0 | |||
| @botonic/cli/0.18.6-alpha.0 darwin-x64 node-v14.16.1 | |||
There was a problem hiding this comment.
Why the node version is changing here?
There was a problem hiding this comment.
nice catch! this is something that is generated automatically by oclif. In practical terms it means I have ran the publish command with node 14 in my local machine. I would downgrade to node 12 when publishing the final package.
elozano98
approved these changes
May 25, 2021
vanbasten17
force-pushed
the
fix/cli-c-flag
branch
from
87385d9 to
4a3dd1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-cflag of deploy command was not working: https://linear.app/hubtype/issue/BOT-413/botoniccli-0185-not-using-c-flagJust pass it as an optional argument to
buildDeployed version to test: https://www.npmjs.com/package/@botonic/cli/v/0.18.6-alpha.0