Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contenful/handoff #1625

Merged
merged 3 commits into from
Jun 23, 2021
Merged

Contenful/handoff #1625

merged 3 commits into from
Jun 23, 2021

Conversation

dpinol
Copy link
Contributor

@dpinol dpinol commented Jun 10, 2021

Description

Create handoff content

Context

There wasn't any content to define the fields of the handoff an its target. With the handoff content we can avoid breaking the flow when there is an agent handoff.

Approach taken / Explain the design

Create a new component with some of the fields of HandOffBuilder:

  • onFinish: can be a payload or a target (Text, Image, Carousel)
  • queue: reference to a desk queue
  • agent: can be an agentEmail or an agentId
  • shadowing: boolean

message: to define the message that will be shown before the handoff
failMessage: to define the message that will be shown if the handoff can't be done

To document / Usage example

Testing

The pull request...

  • has unit tests

@dpinol dpinol force-pushed the contenful/handoff branch from d133d1f to 764fd43 Compare June 11, 2021 06:56
@AinaVendrell AinaVendrell force-pushed the contenful/handoff branch 6 times, most recently from fd0dc31 to 764fd43 Compare June 14, 2021 11:34
Copy link
Contributor Author

@dpinol dpinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

@AinaVendrell AinaVendrell marked this pull request as ready for review June 21, 2021 13:19
@AinaVendrell
Copy link
Contributor

Should onFinish be mandatory? @asastre @guinii @AlbertGom

@asastre
Copy link
Contributor

asastre commented Jun 22, 2021

Should onFinish be mandatory? @asastre @guinii @AlbertGom

I would set it as mandatory since the most common thing to do after a handoff is to show a message or a rating.
If no content has to be shown after a handoff, you can always set a payload that leads to an empty action.

@asastre
Copy link
Contributor

asastre commented Jun 22, 2021

The destination attribute in Handoff can be one of these 3: Queue, Agent Email or Agent ID.

Setting the destination to an Agent Email, would it represent an auto-assign? If so, there's no way to do an auto-assign into a specific Queue to a specific agent, right?
Right now I have to choose between setting a queue or an agent as the destination of the Handoff but doing the handoffs directly in the bots I can determine both in the same handoff.

I think this configuration can't be done with the actual changes in this PR, am I right? If I'm right, I think we should consider adding this type of configuration to Handoff.

@AinaVendrell AinaVendrell requested a review from asastre June 23, 2021 08:02
Copy link
Contributor

@asastre asastre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Nice!! 🚀

@AinaVendrell AinaVendrell merged commit aebcd6c into master Jun 23, 2021
@AinaVendrell AinaVendrell deleted the contenful/handoff branch June 23, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants