-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contenful/handoff #1625
Contenful/handoff #1625
Conversation
d133d1f
to
764fd43
Compare
fd0dc31
to
764fd43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments
packages/botonic-plugin-contentful/src/cms/factories/content-factories.ts
Outdated
Show resolved
Hide resolved
packages/botonic-plugin-contentful/src/cms/factories/content-factories.ts
Outdated
Show resolved
Hide resolved
packages/botonic-plugin-contentful/src/contentful/contents/button.ts
Outdated
Show resolved
Hide resolved
packages/botonic-plugin-contentful/src/contentful/contents/handoff.ts
Outdated
Show resolved
Hide resolved
50305f0
to
1fc4b00
Compare
packages/botonic-plugin-contentful/tests/contentful/contents/handoff.test.ts
Outdated
Show resolved
Hide resolved
0a9dd33
to
e1b6b8c
Compare
e1b6b8c
to
b8313d6
Compare
Should onFinish be mandatory? @asastre @guinii @AlbertGom |
I would set it as mandatory since the most common thing to do after a handoff is to show a message or a rating. |
The Setting the destination to an Agent Email, would it represent an auto-assign? If so, there's no way to do an auto-assign into a specific Queue to a specific agent, right? I think this configuration can't be done with the actual changes in this PR, am I right? If I'm right, I think we should consider adding this type of configuration to |
772790b
to
ab94db7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Nice!! 🚀
Description
Create
handoff
contentContext
There wasn't any content to define the fields of the handoff an its target. With the handoff content we can avoid breaking the flow when there is an agent handoff.
Approach taken / Explain the design
Create a new component with some of the fields of HandOffBuilder:
onFinish
: can be a payload or a target (Text, Image, Carousel)queue
: reference to a desk queueagent
: can be an agentEmail or an agentIdshadowing
: booleanmessage
: to define the message that will be shown before the handofffailMessage
: to define the message that will be shown if the handoff can't be doneTo document / Usage example
Testing
The pull request...