feat(react): Display <Button> components as normal buttons in whatsapp #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y whatsapp buttons
…button and multichannel text components
…of new line in buttons
asastre
requested review from
ericmarcos,
guinii,
vanbasten17,
elozano98 and
AinaVendrell
vanbasten17
reviewed
Jul 7, 2021
packages/botonic-react/tests/components/multichannel/multichannel-button.test.jsx
Outdated
Show resolved
Hide resolved
marcpdw
reviewed
Jul 7, 2021
packages/botonic-react/src/components/multichannel/multichannel-button.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel-button.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel-text.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel-text.jsx
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel-text.jsx
Outdated
Show resolved
Hide resolved
…egenerateMultichannelButtons
Yes, you're right! Added support for whatsapp buttons in Carousels in this commit. Thanks for the observation!! |
vanbasten17
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new attributes (
buttonsAsTextandbuttonsTextSeparator) intextprop forMultichannelcomponent in order to decide to display<Button>components as text or as buttons in whatsapp.Also, allow to display buttons pointing to webviews alongside other buttons (now webview buttons needed to be alone within a
<Text>component)Context
Allow
@botonic/reactMultichannelcomponent to be able to display real buttons in whatsapp.Approach taken / Explain the design
Since only 3 buttons (postback buttons) per message are allowed in whatsapp, if we detect more than 3 buttons within a message we're splitting the message in multiple messages in order to ensure all buttons will be displayed.
Since buttons pointing to URLs are not allowed in whatsapp, they will be displayed as text (the same way it's done right now).
To document / Usage example
Here are some examples of how messages containing buttons will be displayed in whatsapp:
Having this piece of code:
This is what will be displayed in whatsapp:
If we change the value of the
buttonAsTextattribute totrue, in order to display the buttons as text as we do now, this is what will be displayed in whatsapp:Testing
The pull request has unit tests.