Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: configure pre-commit workflow #PLA-695 #1888

Merged
merged 4 commits into from
Sep 22, 2021

Conversation

manuelfidalgo
Copy link
Contributor

Description

Configure pre-commit checks to run in github actions

Context

Before, the checks only ran in local

Approach taken / Explain the design

Include a specific workflow for this

To document / Usage example

Will be triggered on every PR action

Testing

The pull request...

  • has unit tests
  • has integration tests
  • doesn't need tests because... [provide a description]

@github-actions
Copy link

github-actions bot commented Sep 20, 2021

Unit Test Results

  1 files  ±0    7 suites  ±0   3m 24s ⏱️ ±0s
32 tests ±0  32 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d04d577. ± Comparison against base commit d04d577.

♻️ This comment has been updated with latest results.

@manuelfidalgo manuelfidalgo force-pushed the ci/configure-pre-commit branch from c10a31d to 94cef69 Compare September 20, 2021 13:57
@manuelfidalgo manuelfidalgo changed the title ci: configure pre-commit workflow ci: configure pre-commit workflow #PLA-695 Sep 20, 2021
@linear
Copy link

linear bot commented Sep 20, 2021

PLA-695 Configure github action for pre-commit in Botonic

pre-commit is not being triggered in ci: we need to configure it as we do it in Frontend

@manuelfidalgo manuelfidalgo merged commit d04d577 into master Sep 22, 2021
@manuelfidalgo manuelfidalgo deleted the ci/configure-pre-commit branch September 22, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants