Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contentful: custom content model #1900

Merged
merged 4 commits into from
Oct 1, 2021
Merged

Conversation

AlbertGom
Copy link
Contributor

Description

Create custom content

Context

There was no custom content model where you can add custom fields without having to be defined in the plugin.

Approach taken / Explain the design

Created a new component that has id,name and fields. Fields field is a record that has the custom fields defined in contentful.

To document / Usage example

Testing

The pull request...

  • has unit tests

@asastre
Copy link
Contributor

asastre commented Sep 27, 2021

Although I have approved the PR @AlbertGom take a look at the tests, they're failing!

@asastre asastre force-pushed the contentful/custom-content-model branch from 2faf3b4 to 5657f05 Compare September 30, 2021 10:37
@asastre asastre force-pushed the contentful/custom-content-model branch from 5657f05 to 3b9d07d Compare September 30, 2021 10:39
@github-actions
Copy link

github-actions bot commented Sep 30, 2021

Unit Test Results

  1 files  ±0    7 suites  ±0   2m 34s ⏱️ -33s
32 tests ±0  32 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3b9d07d. ± Comparison against base commit 1a09393.

♻️ This comment has been updated with latest results.

@asastre
Copy link
Contributor

asastre commented Sep 30, 2021

The changes done before the last commit allowed to fetch custom content from Contentful only if the content model was named 'custom'.
With the changes done in the last commit allow fetching all type of content models different than the known ones (text, image, button, etc.).
@AlbertGom can you review this last commit?

Copy link
Contributor

@AinaVendrell AinaVendrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@asastre asastre merged commit a1e17f9 into master Oct 1, 2021
@asastre asastre deleted the contentful/custom-content-model branch October 1, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants