Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full stack/refactor router pt2 - split and sort tests #1937

Merged
merged 4 commits into from
Oct 14, 2021
Merged

Full stack/refactor router pt2 - split and sort tests #1937

merged 4 commits into from
Oct 14, 2021

Conversation

vanbasten17
Copy link
Contributor

@vanbasten17 vanbasten17 commented Oct 11, 2021 •
edited
Loading

Description

Depends on: #1936

  • Minor type changes.
  • Splitted and reordered routing tests. (no logic changed at all)

@vanbasten17 vanbasten17 force-pushed the full-stack/refactor-router-pt2-sort-tests branch from dfd0cdf to a0eb609 Compare October 11, 2021 09:55
@vanbasten17 vanbasten17 changed the title chore(core): split and sort routing tests Full stack/refactor router pt2 - split and sort tests Oct 11, 2021
@vanbasten17 vanbasten17 force-pushed the full-stack/refactor-router-pt2-sort-tests branch from 60bbf91 to f44fa21 Compare October 14, 2021 14:57
@vanbasten17 vanbasten17 merged commit aa94217 into full-stack/refactor-router-pt2 Oct 14, 2021
@vanbasten17 vanbasten17 deleted the full-stack/refactor-router-pt2-sort-tests branch October 14, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asastre asastre asastre approved these changes

@ericmarcos ericmarcos Awaiting requested review from ericmarcos

@marcpdw marcpdw Awaiting requested review from marcpdw

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanbasten17 @asastre