Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/device adapter #1988

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Fix/device adapter #1988

merged 2 commits into from
Oct 27, 2021

Conversation

vanbasten17
Copy link
Contributor

Description

  • Initialize current device ASAP when DeviceAdapter is constructed to allow setting the font size in the correct way for iPhone devices. This is, when TextArea's fontSize is called in the very first time, return the expected font size or 'initial'.
  • Give preference to navigator.userAgentData.platform over navigator.platform as it has been deprecated, leading currentDevice to be undefined ow.
  • WebchatResizer onFocus method was called before being constructed. Placing this logic to be executed at the very end of JS event loop.
  • Disabling a log (which is only for Botonic 1.0) to avoid potential customer complaints.

Context

Some things I have noticed after reviewing a pull request regarding scrollable contents.

Approach taken / Explain the design

To document / Usage example

Testing

The pull request...

  • has unit tests
  • has integration tests
  • doesn't need tests because... [provide a description]

@vanbasten17 vanbasten17 merged commit 82c41b5 into master Oct 27, 2021
@vanbasten17 vanbasten17 deleted the fix/device-adapter branch October 27, 2021 08:44
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Oct 27, 2021

Unit Test Results

  1 files  ±0    7 suites  ±0   3m 30s ⏱️ ±0s
32 tests ±0  32 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 82c41b5. ± Comparison against base commit 82c41b5.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants