-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): add imagePreviewer property in theme and allow rendering custom components in webchat #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten17
changed the title
feat(react): working image preview modal
feat(react): image preview modal and opening custom content for modals with Botonic API
Nov 12, 2021
vanbasten17
force-pushed
the
feat/image-previews
branch
2 times, most recently
from
November 17, 2021 14:06
93da22f
to
63b638c
Compare
vanbasten17
force-pushed
the
feat/image-previews
branch
2 times, most recently
from
December 19, 2021 13:39
9f9e526
to
23a818f
Compare
vanbasten17
force-pushed
the
feat/image-previews
branch
2 times, most recently
from
December 20, 2021 16:00
971ad25
to
da3da6d
Compare
vanbasten17
force-pushed
the
feat/image-previews
branch
from
December 21, 2021 09:47
da3da6d
to
ac294a2
Compare
vanbasten17
changed the title
feat(react): image preview modal and opening custom content for modals with Botonic API
feat(react): add imagePreviewer property in theme and allow rendering custom components in webchat
Dec 21, 2021
vanbasten17
force-pushed
the
feat/image-previews
branch
from
December 21, 2021 16:31
f3cf530
to
8b3af07
Compare
Iru89
approved these changes
Dec 22, 2021
vanbasten17
force-pushed
the
feat/image-previews
branch
from
December 22, 2021 12:04
8b3af07
to
1983638
Compare
Merged
vanbasten17
added a commit
that referenced
this pull request
Mar 23, 2023
… custom components in webchat (#2030) * feat(react): working image preview modal * feat(react): botonic API to allow open/close modal with custom modal content * chore(eact): add types for modals * fix(react): correct styles for large images * wip: zoom in/zoom out func * wip: photoswipe working * chore(react): remove share and full-screen * wip * wip(react): setting custom property for imagePreviewer * feat(react): working previewer feature * refactor(react): rename names to not be only bind to imagePreviewer and to be generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the following behaviors in webchat:
theme.imagePreviewer
, it will be rendered when an image (Image
component) within webchat is clicked is clicked. Otherwise, it will behave as before. It is not provided by default by the framework in order to not increase the bundle sizes of all bots.Context
We didn't have a way to add a previewer for images.
Approach taken / Explain the design
Created an external package to be used within this functionality. Example providen below
Desktop:
Mobile:
To document / Usage example
Rendering a custom component with Botonic API:
webchat/index.js
Defining your custom ImagePreviewer:
Testing
The pull request...