Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix cli issues with higher versions of Node #2280

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

vanbasten17
Copy link
Contributor

@vanbasten17 vanbasten17 commented Oct 21, 2022

Description

Fixes for CLI working with higher versions of Node (16, 18).
References:

Context

Currently Botonic CLI was not working correctly with higher versions of Node (16, 18) due to an incompatibility of node-sass with these versions.

To document / Usage example

MacOs

Node Version/Command New Install Serve Deploy
12
14
16
18

Linux

Node Version/Command New Install Serve Deploy
12
14
16 (needs installation of build-essential package) *
18 (needs installation of build-essential package) *

* To install build-essential package do:

  1. $ sudo apt update
  2. $ sudo apt install build-essential

Windows

Node Version/Command New Install Serve Deploy
12
14
16 (needs Desktop development with C++ workload)
18 (needs Desktop development with C++ workload)

@github-actions
Copy link

github-actions bot commented Oct 21, 2022

Unit Test Results

  1 files  ±0    7 suites  ±0   4m 6s ⏱️ ±0s
32 tests ±0  32 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cfd731a. ± Comparison against base commit cfd731a.

♻️ This comment has been updated with latest results.

@vanbasten17 vanbasten17 marked this pull request as ready for review November 7, 2022 12:41
@ericmarcos ericmarcos merged commit cfd731a into master-lts Feb 9, 2023
@ericmarcos ericmarcos deleted the fix/cli-errors branch February 9, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants