Feat: custom user input buttons #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CUSTOM_PROPERTIES
Iru89
requested review from
ericmarcos,
asastre,
vanbasten17,
AinaVendrell and
AlbertGom
asastre
reviewed
Mar 17, 2023
There was a problem hiding this comment.
Agree with @vanbasten17 comments and also I suggest to move the custom rendering logic to the webchat.jsx file (the same way it's done with the SendButton component), let me know if it make sense to you.
Iru89
force-pushed
the
feat/custom-user-input-buttons
branch
from
498aff5 to
206d926
Compare
|
in the commit I have removed the IconContainer that is only used in this button what really changes is the padding but I think it still looks good because I have also changed the styled component UserInputContainer in de next commit |
vanbasten17
force-pushed
the
feat/custom-user-input-buttons
branch
from
1410961 to
636f127
Compare
vanbasten17
added a commit
that referenced
this pull request
Mar 23, 2023
* feat(react): add in CUSTOM_PROPERTIES customEmojiPicker and customAttachments * feat(botonic-react): render the custom component if it exists * feat(botonic-react): render the custom component if it is defined in CUSTOM_PROPERTIES * chore(botonic-react): add build:watch script * refactor(botonic-react): rename functions typo error * feat(botonic-react): create ConditionalAnimation as a component * refactor(botonic-react): put the conditional rendering logic inside each component * refactor(botonic-react): simplify the webchat component * chore(react): bump alpha version * chore(react): bump to 0.21.2 --------- Co-authored-by: Marc Rabat <marcrabat@gmail.com> Co-authored-by: Marc Rabat Pla <35448568+vanbasten17@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the feature to define in the bot the icons to send an emoji and attach a file as you can do with the send text button by declaring a custom component
Context
I didn't want to modify more things but I think the css should also be refactored to reduce the number of nested divs with fixed paddings to separate the elements. As you can see in the image the custom buttons are not well aligned.
Approach taken / Explain the design
To document / Usage example
Before change icons
After change icons
You can define custom components for each button like this
Testing
The pull request...