plugin-flow-builder: resolve the bot's locale by searching the flow's locale array #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iru89
requested review from
asastre,
alexgimenez02,
AinaVendrell,
AlbertGom and
CarlosELorenzo
Iru89
changed the title
Iru89
force-pushed
the
feature/blt-593-task-plugin-flow-builder-always-receives-a-locale-language
branch
from
ade712d to
a791527
Compare
Iru89
changed the base branch from
master-lts
to
feature/blt-590-task-check-agents-availability-on-flow-builder-plugin
asastre
requested changes
Mar 5, 2024
asastre
approved these changes
Mar 5, 2024
Base automatically changed from
feature/blt-590-task-check-agents-availability-on-flow-builder-plugin
to
master-lts
March 5, 2024 15:36
… a locale/language of the flow array
Iru89
force-pushed
the
feature/blt-593-task-plugin-flow-builder-always-receives-a-locale-language
branch
from
2b9e100 to
b50bf08
Compare
Iru89
deleted the
feature/blt-593-task-plugin-flow-builder-always-receives-a-locale-language
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a function to resolve from a locale received from the bot to a locale/language of the flow array.
Context
Before we had this function if the bot passed as locale
es-ESand the flow was only set toesthe plugin failed and the bot did not return a reply. If we had a bot that used generic Englishenfor all countries and the plugin received anen-ESlocale the plugin failed and the bot did not return a reply.Approach taken / Explain the design
The bot will always pass a locale e.g:
es-ES,en-ES,ca-ESIf the plugin has flow for this locale it will use it, otherwise it will look for flow for simple language
es,en,ca