-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin-flow-builder: add support for smart intent nodes #2803
Merged
vanbasten17
merged 5 commits into
use-only-contentID-outside-plugin
from
feature/flow-builder-smart-intents
Mar 27, 2024
Merged
plugin-flow-builder: add support for smart intent nodes #2803
vanbasten17
merged 5 commits into
use-only-contentID-outside-plugin
from
feature/flow-builder-smart-intents
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten17
force-pushed
the
feature/flow-builder-smart-intents
branch
from
March 25, 2024 08:23
afb49e9
to
fbf6ec6
Compare
Iru89
force-pushed
the
node-v20
branch
2 times, most recently
from
March 25, 2024 12:45
eec7317
to
500c822
Compare
Iru89
changed the base branch from
node-v20
to
use-only-contentID-outside-plugin
March 26, 2024 14:30
Iru89
force-pushed
the
feature/flow-builder-smart-intents
branch
from
March 26, 2024 14:37
fbf6ec6
to
b0d230d
Compare
Iru89
force-pushed
the
use-only-contentID-outside-plugin
branch
from
March 26, 2024 15:33
0d4298c
to
459c0fb
Compare
Iru89
force-pushed
the
feature/flow-builder-smart-intents
branch
from
March 26, 2024 15:34
b0d230d
to
a0aa0d2
Compare
…utside action folder
Iru89
approved these changes
Mar 26, 2024
Iru89
changed the title
feat(plugin-flow-builder): add support for smart intent nodes
Plugin-flow-builder: add support for smart intent nodes
Mar 26, 2024
Iru89
changed the title
Plugin-flow-builder: add support for smart intent nodes
plugin-flow-builder: add support for smart intent nodes
Mar 27, 2024
vanbasten17
merged commit Mar 27, 2024
9c1724d
into
use-only-contentID-outside-plugin
1 check passed
Iru89
added a commit
that referenced
this pull request
Mar 27, 2024
## Description This PR includes #2803 and #2790 Removed from version 1.0.0-dev - botonic-api - botonic-pulumi - create-botonic-app package Removes old AI packages that we won't update anymore - botonic-nlp - botonic-intent-classification - botonic-ner Removes the package-lock.json from each package Add the examples folder to the monorepo with the https://github.com/hubtype/botonic-examples but examples using @botonic/dx in the devDependencies and the new version of @botonic/react With node 20 you use npm 10. With npm 10 I created a monorepo using npm workspaces. With this monorepo you do `npm install` in the root of the project and this creates a shared node_modules in the root. You can run scripts for each package from the botonic root. For example `npm run build -w @botonic/core` Change several things about how builds are done using tsc. It adds a tsconfig.esm.base.json and tsconfig.cjs.base.json to the root of the project and extends these two files to create the builds of all packages. ## Context This PR updates many dependencies such as Node, npm, webpack (webpack plugin), jest, eslint (eslint plugins), prettier, axios, etc. It also updates the github actions so that builds are done properly when running tests in the repository. ## Approach taken / Explain the design When using an npm monorepo, symlink internal to the monorepo is used. When using symlink it is necessary to build @botonic/core before making changes to a package that requires `@botonic/core`. For example if you want to change `@botonic/react` code you need to build `@botonic/core` to make the imports work, pass the lint, pass the tests etc. This is also important in the github actions. now you can declare a BUILD_COMMAND for cases where you need to build core first. ## To document / Usage example To start developing using all these new versions of node, npm, monorepo, etc. - Remove all package-lock.json, all node_modules and lib folders - With nvm (or similar) use node 20 and npm 10 - From root folder do an `npm i` - Then an npm build on `@botonic/core` - Then an npm build on `@botonic/react` ## Testing All the tests that already existed are still running locally and in the GitHub repository. Update a @botonic/cli deploy.test.ts that used an example published in the master branch of the external @botonic-examples repository. Now use the examples folder inside the monorepo so that changes can be made and tests can be tested before releasing the example bot version. --------- Co-authored-by: Marc Rabat <35448568+vanbasten17@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
HtSmartIntentNode
models along withgetNodeSmartIntents
to retrieve them from defined flow in flow builder and make use of Smart Intent functionalityContext
Reorder the priority in which user input is resolved in the plugin's pre method: