Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-flow-builder: add support for smart intent nodes #2803

Conversation

vanbasten17
Copy link
Contributor

@vanbasten17 vanbasten17 commented Mar 21, 2024

Description

Added HtSmartIntentNode models along with getNodeSmartIntents to retrieve them from defined flow in flow builder and make use of Smart Intent functionality

Context

Captura de pantalla 2024-03-27 a las 9 12 07

Reorder the priority in which user input is resolved in the plugin's pre method:

  • keywords
  • smart intent
  • intent

image (8)

@vanbasten17 vanbasten17 force-pushed the feature/flow-builder-smart-intents branch from afb49e9 to fbf6ec6 Compare March 25, 2024 08:23
@Iru89 Iru89 force-pushed the node-v20 branch 2 times, most recently from eec7317 to 500c822 Compare March 25, 2024 12:45
@Iru89 Iru89 changed the base branch from node-v20 to use-only-contentID-outside-plugin March 26, 2024 14:30
@Iru89 Iru89 force-pushed the feature/flow-builder-smart-intents branch from fbf6ec6 to b0d230d Compare March 26, 2024 14:37
@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 26, 2024
@vanbasten17 vanbasten17 marked this pull request as ready for review March 26, 2024 14:38
Copy link

github-actions bot commented Mar 26, 2024

Test Results

30 tests  +29   30 ✅ +29   4m 14s ⏱️ + 4m 12s
 6 suites + 5    0 💤 ± 0 
 1 files   ± 0    0 ❌ ± 0 

Results for commit a0aa0d2. ± Comparison against base commit 459c0fb.

♻️ This comment has been updated with latest results.

@Iru89 Iru89 force-pushed the use-only-contentID-outside-plugin branch from 0d4298c to 459c0fb Compare March 26, 2024 15:33
@Iru89 Iru89 force-pushed the feature/flow-builder-smart-intents branch from b0d230d to a0aa0d2 Compare March 26, 2024 15:34
@Iru89 Iru89 changed the title feat(plugin-flow-builder): add support for smart intent nodes Plugin-flow-builder: add support for smart intent nodes Mar 26, 2024
@Iru89 Iru89 changed the title Plugin-flow-builder: add support for smart intent nodes plugin-flow-builder: add support for smart intent nodes Mar 27, 2024
@vanbasten17 vanbasten17 merged commit 9c1724d into use-only-contentID-outside-plugin Mar 27, 2024
1 check passed
@vanbasten17 vanbasten17 deleted the feature/flow-builder-smart-intents branch March 27, 2024 10:18
Iru89 added a commit that referenced this pull request Mar 27, 2024
## Description
This PR includes #2803 and #2790

Removed from version 1.0.0-dev
- botonic-api
- botonic-pulumi
- create-botonic-app package

Removes old AI packages that we won't update anymore
- botonic-nlp
- botonic-intent-classification
- botonic-ner

Removes the package-lock.json from each package

Add the examples folder to the monorepo with the
https://github.com/hubtype/botonic-examples but examples using
@botonic/dx in the devDependencies and the new version of @botonic/react

With node 20 you use npm 10. 
With npm 10 I created a monorepo using npm workspaces. With this
monorepo you do `npm install` in the root of the project and this
creates a shared node_modules in the root. You can run scripts for each
package from the botonic root. For example `npm run build -w
@botonic/core`

Change several things about how builds are done using tsc. It adds a
tsconfig.esm.base.json and tsconfig.cjs.base.json to the root of the
project and extends these two files to create the builds of all
packages.

## Context

This PR updates many dependencies such as Node, npm, webpack (webpack
plugin), jest, eslint (eslint plugins), prettier, axios, etc.
It also updates the github actions so that builds are done properly when
running tests in the repository.

## Approach taken / Explain the design

When using an npm monorepo, symlink internal to the monorepo is used.
When using symlink it is necessary to build @botonic/core before making
changes to a package that requires `@botonic/core`.
For example if you want to change `@botonic/react` code you need to
build `@botonic/core` to make the imports work, pass the lint, pass the
tests etc.
This is also important in the github actions. now you can declare a
BUILD_COMMAND for cases where you need to build core first.

## To document / Usage example

To start developing using all these new versions of node, npm, monorepo,
etc.

- Remove all package-lock.json, all node_modules and lib folders
- With nvm (or similar) use node 20 and npm 10
- From root folder do an `npm i` 
- Then an npm build on `@botonic/core`
- Then an npm build on `@botonic/react`

## Testing

All the tests that already existed are still running locally and in the
GitHub repository.

Update a @botonic/cli deploy.test.ts that used an example published in
the master branch of the external @botonic-examples repository. Now use
the examples folder inside the monorepo so that changes can be made and
tests can be tested before releasing the example bot version.

---------

Co-authored-by: Marc Rabat <35448568+vanbasten17@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants