plugin-flow-builder: bot action limit characters #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten17
approved these changes
May 7, 2024
AinaVendrell
approved these changes
May 7, 2024
…nPayload function, and rename constant
Iru89
force-pushed
the
BLT-718-bug-bot-action-limit-characters
branch
from
2f9a5cc to
58b0d20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using a Bot Action node with parameters that is connected to a follow up. It is easy to exceed the character limit allowed by Telegram (64bytes = 64 characters).
Context
When connecting a BotActionNode to a button the payload will be ba|BotActionNodeUUID|source_x
In the pre function of the plugin: first the |source_x is removed, then if a payload starting with ba| is detected the BotActionNode is obtained using the botActionNodeUUID and the payload is replaced by the payload plus the parameters defined in the BotActionNode.
When we get to the bot routes we have the payload with the parameters.
In the action we can continue using the getPayloadParams function as we did before.
Testing
Add config for jest and github action
Add test for first interaction
Add test for bot action node