Botonic: upgrade typescript to 5.5.3 #2874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results30 tests 30 ✅ 5m 9s ⏱️ Results for commit 11575f0. ♻️ This comment has been updated with latest results. |
vanbasten17
changed the title
vanbasten17
reviewed
Jul 15, 2024
vanbasten17
reviewed
Jul 15, 2024
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "extends": "./tsconfig.base.json", | |||
| "compilerOptions": { | |||
| "module": "ES2022", | |||
| "module": "Node16", | |||
There was a problem hiding this comment.
beware with this change. Here https://www.typescriptlang.org/tsconfig/#module is stated that this changes the moduleResolution. I think we have to be sure that the compiled code is the one we expect
There was a problem hiding this comment.
Yes you are right I had to change this to make the build but now it is failing some tests in core related to regexp. I have to check better how the build is made
vanbasten17
reviewed
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade typescript used in botonic to v5.5.3
Context
Remove a type in the Contentful plugin as it is not typed correctly and when inferring the type automatically with the new version of typescript, an error occurs.
Removes the use of as T (in several flow builder plugin files) after using a filter on an array as the new version of typescript correctly infers the type.